Re: log_rotation_age integer overflow display quirk - Mailing list pgsql-hackers

From Bernd Helmle
Subject Re: log_rotation_age integer overflow display quirk
Date
Msg-id 139D8A05100D6654779A0F14@imhotep.credativ.de
Whole thread Raw
In response to log_rotation_age integer overflow display quirk  (Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>)
Responses Re: log_rotation_age integer overflow display quirk  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
--On Freitag, Juli 04, 2008 11:31:07 +0200 Stefan Kaltenbrunner 
<stefan@kaltenbrunner.cc> wrote:

> I just noticed that setting log_rotation_age to a value larger than 24
> days results in rather weird output (I have not actually tested yet if
> that affects the functionality too or just the output):
>
>
> test=# show log_rotation_age;
>   log_rotation_age
> ------------------
>   -2134967296ms
> (1 row)

This seems to be a bug in _ShowOption(), where the corresponding value is 
converted into milliseconds to get the biggest possible time unit to 
display. This overflows the result variable (which is declared as int), 
causing this strange output.

--  Thanks
                   Bernd


pgsql-hackers by date:

Previous
From: Zdenek Kotala
Date:
Subject: Re: Concurrent Restores
Next
From: Zdenek Kotala
Date:
Subject: Review: DTrace probes (merged version)