Re: GinPageIs* don't actually return a boolean - Mailing list pgsql-hackers

From Tom Lane
Subject Re: GinPageIs* don't actually return a boolean
Date
Msg-id 13999.1455287960@sss.pgh.pa.us
Whole thread Raw
In response to Re: GinPageIs* don't actually return a boolean  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: GinPageIs* don't actually return a boolean
Re: GinPageIs* don't actually return a boolean
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Feb 12, 2016 at 8:48 AM, Andres Freund <andres@anarazel.de> wrote:
>> E.g. if you include stdbool.h [ ginStepRight breaks ]

> Ah-ha.  OK, now I get it.  So then I agree we should back-patch this
> at least as far as 9.3 where MSVC 2013 became a supported platform,

Um, no, that does not follow.  The unanswered question here is why,
when we *have not* included stdbool.h and *have* typedef'd bool as
just plain "char", we would get C99 bool behavior.  There is something
happening there that should not be happening, and I'm not really satisfied
with the explanation "Microsoft is brain-dead as usual".  I think we
should dig deeper, because whatever is going on there may have deeper
effects than we now realize.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: pg_basebackup vs WAL fetching
Next
From: Robert Haas
Date:
Subject: Re: CustomScan in a larger structure (RE: CustomScan support on readfuncs.c)