Re: [PATCH] ltree, lquery, and ltxtquery binary protocol support - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] ltree, lquery, and ltxtquery binary protocol support
Date
Msg-id 13998.1585777035@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] ltree, lquery, and ltxtquery binary protocol support  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] ltree, lquery, and ltxtquery binary protocol support  (Nino Floris <mail@ninofloris.com>)
List pgsql-hackers
I wrote:
> Fortunately for the odds of getting this patch accepted, we just
> pushed an ALTER TYPE improvement that will solve your problem [1].
> Please replace ltree--1.2.sql with an upgrade script that uses
> that, and resubmit.

I decided it would be a shame for this to miss v13, seeing that
(a) it'd provide real-world use of that ALTER TYPE code, and
(b) we already bumped ltree's extension version for v13.

So I went ahead and rebased this, reviewed and pushed it.  The
main non-cosmetic thing I changed, other than using ALTER TYPE,
was that you had the output functions looking like this:

    pq_sendtext(&buf, res, pg_mbstrlen(res));

That's just wrong; it should be plain strlen().  Did you copy
that coding from someplace?  I could not find any similar
occurrences in our code tree.

            regards, tom lane



pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: backup manifests
Next
From: Tomas Vondra
Date:
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)