Re: What to do with inline warnings? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: What to do with inline warnings?
Date
Msg-id 1390.1210794516@sss.pgh.pa.us
Whole thread Raw
In response to Re: What to do with inline warnings?  (Gregory Stark <stark@enterprisedb.com>)
List pgsql-hackers
Gregory Stark <stark@enterprisedb.com> writes:
> Fwiw, these two call sites are only for when HeapTupleSatisfiesMVCC finds a
> tuples which has been moved away by VACUUM FULL... The latter for when it
> finds such a tuple but the VACUUM FULL aborted.

> It seems quite likely that the compiler is actually right (by chance) and we
> shouldn't be optimizing those cases at the expense of more common cases.

I trimmed the original message quite a bit --- there were a lot more
than two call sites that it was deciding not to inline.  Maybe it's
making the right choices or maybe not.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Gregory Stark
Date:
Subject: Re: What to do with inline warnings?
Next
From: Alvaro Herrera
Date:
Subject: Re: bug in localized \df+ output