Re: DROP DATABASE always seeing database in use - Mailing list pgsql-hackers

From Tom Lane
Subject Re: DROP DATABASE always seeing database in use
Date
Msg-id 139.1217914874@sss.pgh.pa.us
Whole thread Raw
In response to Re: DROP DATABASE always seeing database in use  (Jens-Wolfhard Schicke <drahflow@gmx.de>)
Responses Re: DROP DATABASE always seeing database in use  ("Robert Haas" <robertmhaas@gmail.com>)
List pgsql-hackers
Jens-Wolfhard Schicke <drahflow@gmx.de> writes:
> Tom Lane wrote:
>> ERROR: database "%s" is being accessed by other users
>> DETAIL: There are %d session(s) and %d prepared transaction(s) using the database.
>> 
>> I'm aware that this phrasing might not translate very nicely ... anyone
>> have a suggestion for better wording?

> I can only estimate translation effort into German, but how about:

> DETAIL: Active users of the database: %d session(s), %d prepared transaction(s)

Hmmm ... what I ended up committing was code that special-cased the
common cases where you only have one or the other, ie
   /*    * We don't worry about singular versus plural here, since the English    * rules for that don't translate very
well. But we can at least avoid    * the case of zero items.    */   if (notherbackends > 0 && npreparedxacts > 0)
errdetail("There are %d other session(s) and %d prepared transaction(s) using the database.",
notherbackends,npreparedxacts);   else if (notherbackends > 0)       errdetail("There are %d other session(s) using the
database.",                notherbackends);   else       errdetail("There are %d prepared transaction(s) using the
database.",                npreparedxacts);
 

Your proposal seems fine for the first case but a bit stilted for the
other two.  Or maybe that's just me.

Of course, we don't *have* to do it as above at all, if "0 prepared
transactions" doesn't bother people.

Ideas anybody?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Automatic Client Failover
Next
From: David Fetter
Date:
Subject: PL/LOLCODE [was Re: [PATCH] "\ef " in psql]