Re: Macros for typtype (was Re: Arrays of Complex Types) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Macros for typtype (was Re: Arrays of Complex Types)
Date
Msg-id 13829.1175394686@sss.pgh.pa.us
Whole thread Raw
In response to Re: Macros for typtype (was Re: Arrays of Complex Types)  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: Macros for typtype (was Re: Arrays of Complex Types)  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
>>> I just realized that I need to check every usage of typtype to be
>>> sure that the enums patch is sane.  So, barring objection, I intend
>>> to take this opportunity to make the code stop referring directly
>>> to 'b', 'c' etc whereever possible.  Any objections to these names?

> Why not enums? ;-)

Well, macros is how we do it elsewhere for "char" system columns.
I'm not sure we could rely on the behavior if we declared
pg_type.typtype as an enum type ... and if we don't, there's not
much point.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Re: Bug in UTF8-Validation Code?
Next
From: Mark Dilger
Date:
Subject: Re: Bug in UTF8-Validation Code?