Re: Fix for win32 stat() problems - Mailing list pgsql-patches

From Tom Lane
Subject Re: Fix for win32 stat() problems
Date
Msg-id 1380.1207838581@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fix for win32 stat() problems  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-patches
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Andrew Dunstan wrote:
>> How about #defining safe_stat to be pg_win32_safe_stat on Windows and
>> simply stat elsewhere? Then use safe_stat at the places you consider
>> critical.

> I would couple this with a pgwin32_unsafe_stat on Windows, which changes
> the size value to 0, so that if anyone gets it wrong it's immediately
> obvious.

It's only worth having two versions if someone can show that there's
actually going to be a performance problem from the extra syscall.
I don't believe we use stat() in any place where it's really gonna
matter much ...

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Fix for win32 stat() problems
Next
From: Magnus Hagander
Date:
Subject: Re: Fix for win32 stat() problems