Re: missing SSI check in heapgettup_pagemode() ? - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: missing SSI check in heapgettup_pagemode() ?
Date
Msg-id 1378403774.52392.YahooMailNeo@web162904.mail.bf1.yahoo.com
Whole thread Raw
In response to missing SSI check in heapgettup_pagemode() ?  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

> I was scrolling heapgettup() and heapgettup_pagemode() in parallel, and
> noticed that the former calls CheckForSerializableConflictOut() for
> tuples read, and the latter doesn't.  Is there a reason for this
> discrepancy?  If so, I think it warrants a comment about the missing
> check.

That is covered in heapgetpage().

Do you want to offer a patch to add a comment to that effect, or
would you prefer that I do?

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: missing SSI check in heapgettup_pagemode() ?
Next
From: Tom Lane
Date:
Subject: Re: strange IS NULL behaviour