Re: Eliminating pg_catalog.pg_rewrite.ev_attr - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: Eliminating pg_catalog.pg_rewrite.ev_attr
Date
Msg-id 1378317117.39500.YahooMailNeo@web162903.mail.bf1.yahoo.com
Whole thread Raw
In response to Re: Eliminating pg_catalog.pg_rewrite.ev_attr  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Eliminating pg_catalog.pg_rewrite.ev_attr
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Shouldn't attribute_used() be removed from rewriteManip.h?

Yeah, I don't know how I missed that.  Thanks.

> I was a bit surprised by your removal of the
> rangeTableEntry_used() test in the hunk at
> rewriteHandler.c:1273ff.  That's probably all right, but it takes
> this out of the realm of a mechanical change.

[ also questioned by Álvaro ]

I'll leave that as it was -- it can be discussed separately from
the mechanical changes.

New patch attached.

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [9.4] Make full_page_writes only settable on server start?
Next
From: Robert Haas
Date:
Subject: Re: ENABLE/DISABLE CONSTRAINT NAME