Re: pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY
Date
Msg-id 13779.1200433544@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY  (Simon Riggs <simon@2ndquadrant.com>)
List pgsql-committers
Simon Riggs <simon@2ndquadrant.com> writes:
> That's what the docs say, but Tom's patch also adds lines to handle
> NOTIFY, which is what prompted the question.

I don't believe that code can get executed given the current backend
design.  I just put it in because the protocol spec says (and always
has said)

Note: At present, NotificationResponse can only be sent outside a
transaction, and thus it will not occur in the middle of a
command-response series, though it might occur just before
ReadyForQuery. It is unwise to design frontend logic that assumes that,
however. Good practice is to be able to accept NotificationResponse at
any point in the protocol.


            regards, tom lane

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Be less wishy-washy in the documentation and comments about