Re: WIP: log query in auto-explain - Mailing list pgsql-hackers

From Tom Lane
Subject Re: WIP: log query in auto-explain
Date
Msg-id 13756.1258922888@sss.pgh.pa.us
Whole thread Raw
In response to WIP: log query in auto-explain  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: WIP: log query in auto-explain
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> I put the attached together a while ago and neglected to send it. 
> Basically it includes the text of the query being explained in the 
> explain output.

I'm pretty certain this will dump core in some contexts --- you should
not assume that sourceText is always available.

Should we be worried about security implications of displaying the query
text?

> I think it's more important to include the query text when using 
> auto_explain than in other explain uses, which is why I did it this way. 
> But I could be persuaded that we should always include it.

I think this is just useless noise in every other case.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Stephan Szabo
Date:
Subject: Re: Partitioning option for COPY
Next
From: Greg Stark
Date:
Subject: Re: "Not safe to send CSV data" message