Re: fallocate / posix_fallocate for new WAL file creation (etc...) - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: fallocate / posix_fallocate for new WAL file creation (etc...)
Date
Msg-id 1372702646.19747.75.camel@jdavis
Whole thread Raw
In response to Re: fallocate / posix_fallocate for new WAL file creation (etc...)  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: fallocate / posix_fallocate for new WAL file creation (etc...)
List pgsql-hackers
On Tue, 2013-07-02 at 02:13 +0900, Fujii Masao wrote:
> Even in that case, if a user can easily know which platform posix_fallocate
> should be used in, we can commit the patch with the configurable GUC
> parameter.

I disagree here. We're not talking about a huge win; this speedup may
not even be detectable on a running system.

I think Robert summarized the reason for the patch best: "I mean, if
posix_fallocate() is faster, then it's just faster, right?". But if we
need a new GUC, and DBAs now have one more thing they need to test about
their platform, then that argument goes out the window.

Regards,Jeff Davis





pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: changeset generation v5-01 - Patches & git tree
Next
From: Robert Haas
Date:
Subject: Re: Move unused buffers to freelist