Re: [PATCH] Remove useless USE_PGXS support in contrib - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Remove useless USE_PGXS support in contrib
Date
Msg-id 1371610287.13762.22.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: [PATCH] Remove useless USE_PGXS support in contrib  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On Fri, 2013-06-14 at 09:32 -0400, Andrew Dunstan wrote:
> I do think we need to make sure that we have at least buildfarm
> coverage of pgxs module building and testing. I have some coverage of
> a few extensions I have written, which exercise that, so maybe that
> will suffice. If not, maybe we need to have one module that only
> builds via pgxs and is build after an install (i.e. not via the
> standard contrib build). 

The way to test pgxs is to build actual pgxs modules, and possibly some
unit tests made for the purpose.  Testing with fake hybrid modules that
will never actually appear that way in practice isn't going to satisfy
anyone.





pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Bugfix and new feature for PGXS
Next
From: Peter Eisentraut
Date:
Subject: Re: [PATCH] Remove useless USE_PGXS support in contrib