Re: pg_filedump 9.3: checksums (and a few other fixes) - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: pg_filedump 9.3: checksums (and a few other fixes)
Date
Msg-id 1370884212.6384.2.camel@jdavis-laptop
Whole thread Raw
In response to Re: pg_filedump 9.3: checksums (and a few other fixes)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_filedump 9.3: checksums (and a few other fixes)
List pgsql-hackers
On Mon, 2013-06-10 at 11:38 -0400, Tom Lane wrote:
> The thing I'm not too happy about is having to copy the checksum code
> into pg_filedump.  We just got rid of the need to do that for the CRC
> code, and here it is coming back again.  Can't we rearrange the core
> checksum code similarly to what we did for the CRC stuff recently,
> so that you only need access to a .h file for it?

The CRC implementation is entirely in header files. Do you think we need
to go that far, or is it fine to just put it in libpgport and link that
to pg_filedump?

Regards,Jeff Davis





pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: JSON and unicode surrogate pairs
Next
From: Alvaro Herrera
Date:
Subject: Re: pg_filedump 9.3: checksums (and a few other fixes)