Re: Substituting Checksum Algorithm (was: Enabling Checksums) - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: Substituting Checksum Algorithm (was: Enabling Checksums)
Date
Msg-id 1367023495.11576.262.camel@sussancws0025
Whole thread Raw
In response to Re: Substituting Checksum Algorithm (was: Enabling Checksums)  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
On Sat, 2013-04-27 at 00:20 +0200, Andres Freund wrote:
> CFLAGS_VECTORIZATION? EXTRA sounds to generic to me.

I went with CFLAGS_VECTOR to be a little shorter while still keeping
some meaning.

> I think it would be better to have a PGAC_PROG_CC_VAR_OPT or so which
> assigns the flag to some passed variable name. Then we can reuse it for
> different vars and I have the feeling those will come. And having a
> CFLAGS_VECTOR_OPT would just be stupid ;)

Good suggestion; done.

Thank you for the review. New renamed patch attached for the build
options only (the other patch for the FNV checksum algorithm is
unchanged).

Regards,
    Jeff Davis

Attachment

pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: [COMMITTERS] pgsql: Fix collation assignment for aggregates with ORDER BY.
Next
From: Jeff Davis
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Fix collation assignment for aggregates with ORDER BY.