boolean abuse in geo_ops.c - Mailing list pgsql-hackers

From Peter Eisentraut
Subject boolean abuse in geo_ops.c
Date
Msg-id 1366681890.15557.2.camel@vanquo.pezone.net
Whole thread Raw
List pgsql-hackers
The function

static char *
path_encode(bool closed, int npts, Point *pt)

is actually occasionally passed -1 as its first parameter to mean
something like "neither" or "don't print any delimiters".  That doesn't
seem like good style.  Maybe this should be split off into another bool
parameter named delimited or something?  Or the argument could be made
into an integer.






pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Enabling Checksums
Next
From: Stephen Frost
Date:
Subject: Re: GSOC Student Project Idea