Re: [Util] Warn and Remove Invalid GUCs - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [Util] Warn and Remove Invalid GUCs
Date
Msg-id 1361409.1747859938@sss.pgh.pa.us
Whole thread Raw
In response to [Util] Warn and Remove Invalid GUCs  ("David G. Johnston" <david.g.johnston@gmail.com>)
Responses Re: [Util] Warn and Remove Invalid GUCs
List pgsql-hackers
Shaik Mohammad Mujeeb <mujeeb.sk@zohocorp.com> writes:
> Currently, if there's a typo in an extension name while adding a GUC to postgresql.conf, PostgreSQL server starts up
silentlywithout any warning. This can be misleading, as one might assume the configuration has been correctly applied,
whenin fact the value hasn’t been set due to the typo. 

Well, yeah, because the core server has no way to identify bogus
extension GUCs if the relevant extension isn't loaded.  We do
already complain about such things at extension load time.

> To improve this experience, I’m proposing a patch that issues a
> warning for such invalid GUC entries.

How will you know they are invalid?  All I see in the patch is
a syntactic check, which looks quite redundant with
assignable_custom_variable_name().

            regards, tom lane



pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: [Util] Warn and Remove Invalid GUCs
Next
From: Bruce Momjian
Date:
Subject: Re: proposal: schema variables