Re: BUG #2495: -i start up option blows pg_ctl program. - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #2495: -i start up option blows pg_ctl program.
Date
Msg-id 1360.1151119925@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #2495: -i start up option blows pg_ctl program.  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: BUG #2495: -i start up option blows pg_ctl program.
List pgsql-bugs
Alvaro Herrera <alvherre@commandprompt.com> writes:
> There is indeed a bug in pg_ctl here.  We are reporting an error which
> getopt_long already reported; and furthermore, optarg is not set by that
> function in case of error.  This is the fix:

Good catch, but I'd suggest not just removing the write_stderr but
adding a comment in its place:

    /* getopt_long already issued a suitable error message */

Please commit fix in all relevant branches.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: BUG #2495: -i start up option blows pg_ctl program.
Next
From: "Magnus Hagander"
Date:
Subject: Re: BUG #2493: bug with initdb under an administrator