Re: PL/perl should fail on configure, not make - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: PL/perl should fail on configure, not make
Date
Msg-id 1357705974.25412.2.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: PL/perl should fail on configure, not make  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, 2013-01-08 at 22:37 -0500, Tom Lane wrote:
> We could try adding an AC_TRY_LINK test using perl_embed_ldflags,
> but given the weird stuff happening to redefine that value on Windows
> in plperl/GNUmakefile I think there's a serious risk of breaking
> Cygwin builds.  Since I lack access to either Cygwin or a platform on
> which there's a problem today, I'm not going to be the one to mess
> with it.

For these and similar reasons, I think it's best not to mess with this
too much.  It should fail where it actually fails.  We shouldn't be
duplicating that logic in a remote place to predict that something will
fail later.  In some cases, this is rather safe and easy and useful as a
service to the user, but once it gets slightly complicated, it can only
go wrong.





pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: I s this a bug of spgist index in a heavy write condition?
Next
From: Peter Eisentraut
Date:
Subject: Re: psql \l to accept patterns