Re: Event Triggers: adding information - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Event Triggers: adding information
Date
Msg-id 1356840827.20017.15.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: Event Triggers: adding information  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Event Triggers: adding information  (Dimitri Fontaine <dimitri@2ndQuadrant.fr>)
List pgsql-hackers
On Sat, 2012-12-29 at 08:11 -0500, Robert Haas wrote:
> On Tue, Dec 25, 2012 at 1:42 PM, Dimitri Fontaine
> <dimitri@2ndquadrant.fr> wrote:
> > Robert Haas <robertmhaas@gmail.com> writes:
> >>> Also, keep in mind we want the ObjectID in all CREATE, ALTER and DROP
> >>> statements, so my current patch is still some bricks shy of a load… (I
> >>> added ObjectID only in the commands I added rewrite support for, apart
> >>> from DROP).
> >>
> >> I shall rely on you to provide those bricks which are still missing.
> >
> > Please find attached a patch to change most functions called from
> > standard_ProcessUtility() to return an Oid (passes `make
> > maintainer-clean; configure; make install check`). Most of them only,
> > because it only make sense for functions touching an object that exists
> > in the catalogs and have a distinct Oid.
> 
> OK, I committed this.

There is a new compiler warning coming from this, I believe:

copy.c: In function ‘DoCopy’:
copy.c:835:2: error: ‘relid’ may be used uninitialized in this function [-Werror=maybe-uninitialized] return relid; ^
copy.c:753:6: note: ‘relid’ was declared here Oid         relid;     ^





pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Documentation bug for LDAP authentication
Next
From: Peter Geoghegan
Date:
Subject: Re: enhanced error fields