Re: ALTER command reworks - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: ALTER command reworks
Date
Msg-id 1349299567-sup-441@alvh.no-ip.org
Whole thread Raw
In response to Re: ALTER command reworks  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Excerpts from Alvaro Herrera's message of mié oct 03 18:25:54 -0300 2012:
> Excerpts from Kohei KaiGai's message of lun sep 10 08:08:32 -0300 2012:
>
> > As attached, I split off the original one into three portions; for set-schema,
> > set-owner and rename-to. Please apply them in order of patch filename.
> > Regarding to the error message, RenameErrorMsgAlreadyExists() was added
> > to handle per object type messages in case when aclcheck_error() is not
> > available to utilize.
>
> I have pushed the regression tests and parts 1 and 2.  Only part 3 is
> missing from this series, but I'm not as sure about that one as the
> other two.  Not really a fan of RenameErrorMsgAlreadyExists() as coded,
> but I'll think more about it.

I forgot to mention: I think with a little more effort (a callback to be
registered as the permission check to run during SET OWNER, maybe?) we
could move the foreign stuff and event triggers into the generic SET
OWNER implementation.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: ALTER command reworks
Next
From: Michael Paquier
Date:
Subject: Re: Support for REINDEX CONCURRENTLY