Excerpts from Tom Lane's message of vie sep 14 17:48:35 -0300 2012:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Here's an updated version of both patches, as well as a third patch that
> > converts the cc_node list link in catcache.c into an slist.
>
> There's a lot of stuff here that seems rather unfortunate and/or sloppy.
>
> Does it even compile? The 0002 patch refers to a typedef ilist_d_head
> that I don't see defined anywhere. (It would be good to shorten that
> name by a couple of characters anyway, for tab-stop alignment reasons.)
Hm, I might have submitted the wrong 0002 file. Sorry about that. (The
correct file would have the right typedef names and a couple of bugfixes
but it'd be pretty similar to what you read.)
> [many useful comments]
>
> Not a full review, just some things that struck me in a quick scan...
Great stuff nonetheless, many thanks. I will see about submitting an
improved version.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
