Re: psql output locations - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: psql output locations
Date
Msg-id 1345220452-sup-4113@alvh.no-ip.org
Whole thread Raw
In response to Re: psql output locations  (Bruce Momjian <bruce@momjian.us>)
Responses Re: psql output locations
List pgsql-hackers
Excerpts from Bruce Momjian's message of vie ago 17 11:17:58 -0400 2012:
> On Wed, Dec 14, 2011 at 10:57:25AM -0500, Robert Haas wrote:
> > On Wed, Dec 14, 2011 at 4:45 AM, Magnus Hagander <magnus@hagander.net> wrote:
> > >>> * There are a number of things that are always written to stdout, that
> > >>> there is no way to redirect. In some cases it's interactive prompts -
> > >>> makes sense - but also for example the output of \timing goes to
> > >>> stdout always. Is there some specific logic behind what/when this
> > >>> should be done?
> > >>
> > >> Everything that is not an error goes to stdout, no?  Except the query
> > >> output, if you change it.
> > >>
> > >> Maybe the way to do what you want is to invent a new setting that
> > >> temporarily changes stdout.
> > >
> > > Yeah, that might be it. Or I need separate settings for "put errors in
> > > the query output stream" and "put non-query-output-but-also-non-errors
> > > in the query output stream". The effect would be the same, I guess...
> >
> > That seems an awful lot harder (and messier) than just changing the
> > all the call sites to use the same error-reporting function.
>
> I have done as you suggested with the attached patch.

The very first hunk in your patch changes code that seems to be
explicitely checking the "interactive" flag.  Is the change really
wanted there?  Note Magnus explicitely commented about those in his
original post.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: Re: Planner avoidance of index only scans for partial indexes
Next
From: Bruce Momjian
Date:
Subject: Re: psql output locations