Re: 64-bit pgbench V2 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: 64-bit pgbench V2
Date
Msg-id 13407.1278375444@sss.pgh.pa.us
Whole thread Raw
In response to 64-bit pgbench V2  (Greg Smith <greg@2ndquadrant.com>)
Responses Re: 64-bit pgbench V2
Re: 64-bit pgbench V2
List pgsql-hackers
Greg Smith <greg@2ndquadrant.com> writes:
> The main tricky part was figuring how to convert the \setshell 
> implementation.  That uses strtol to parse the number that should have 
> been returned by the shell call.  It turns out there are a stack of ways 
> to do something similar but return 64 bits instead:

Please choose a way that doesn't introduce new portability assumptions.
The backend gets along fine without strtoll, and I don't see why pgbench
should have to require it.

(BTW, I don't actually believe that the proposed code works at all,
since in general strtoll or other variants aren't going to be macros,
but plain functions.)
        regards, tom lane


pgsql-hackers by date:

Previous
From: Greg Smith
Date:
Subject: 64-bit pgbench V2
Next
From: Robert Haas
Date:
Subject: Re: 64-bit pgbench V2