Re: [HACKERS] Source code format vote - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Source code format vote
Date
Msg-id 13397.946566660@sss.pgh.pa.us
Whole thread Raw
In response to Source code format vote  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [HACKERS] Source code format vote
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Current votes are:
> (8)     8-space tabs:   Tom Lane, Peter E., Massimo, Jan, Hiroshi, Peter M.,
>                         Michael, Tatsuo
> (5)     4-space tabs:   Bruce, Andreas, Vince, Vadim, D'Arcy

>         open bracket on if () line:
> (7)     yes:    Massimo, Peter, Vince, Tom Lane, Peter M., Marc, Tatsuo  
> (6)     no:     Bruce, Vadim, D'Arcy, Jan, Hiroshi, Michael M.

> Looks like radical change will come to our source code format for 7.0.

It looks to me like there is consensus to change the tab spacing (which
is NOT the same as the logical indent step, for those newcomers who
don't seem to be aware of the difference).

However, I don't see a consensus to change the bracket layout.
7-to-6 is not enough of a margin to justify a wholesale code change.
Especially considering that my original vote was NO, which Bruce chose
to interpret as YES ;-).  Change it back to NO, and the vote is the
other way.

I think what we have is a consensus to change the physical tab spacing
but leave the look of the code alone...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: AW: [HACKERS] correlated subquery
Next
From: Stephen Birch
Date:
Subject: HEAP_MOVED_IN error during vacuum?