Re: BUG #3730: Creating a swedish dictionary fails - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #3730: Creating a swedish dictionary fails
Date
Msg-id 13391.1194634167@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #3730: Creating a swedish dictionary fails  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: BUG #3730: Creating a swedish dictionary fails  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-bugs
Alvaro Herrera <alvherre@commandprompt.com> writes:
> I am wondering if the newline being included in the token could be
> causing a problem.

Nope.  I traced through it and the problem is that char2wchar() is
completely brain-dead: at some places it thinks that "len" is the
length of the output wchar array, and at others it thinks that "len"
is the number of bytes in the input.  In particular, _t_isalpha()
fails completely for any multibyte character, because the pnstrdup
call truncates the character to 1 byte.

After looking at the callers I'm inclined to think that the only
safe way to implement this routine is to change its API to provide
both counts.  Comments?

            regards, tom lane

pgsql-bugs by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: BUG #3737: lower/upper fails to match extended chars in LATIN1
Next
From: Alvaro Herrera
Date:
Subject: Re: BUG #3730: Creating a swedish dictionary fails