Re: PL/Python result set slicing broken in Python 3 - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: PL/Python result set slicing broken in Python 3
Date
Msg-id 1336671900.29567.11.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: PL/Python result set slicing broken in Python 3  (Jan Urbański <wulczer@wulczer.org>)
Responses Re: PL/Python result set slicing broken in Python 3
List pgsql-hackers
On lör, 2012-05-05 at 22:45 +0200, Jan Urbański wrote:
> Apparently once you implement PyMappingMethods.mp_subscript you can
> drop PySequenceMethods.sq_slice, but I guess there's no harm in
> keeping it (and I'm not sure it'd work on Python 2.3 with only
> mp_subscript implemented).

Committed this now.

From test coverage reports, I now see that PLy_result_ass_item() is no
longer called.  That's probably OK, if assignments are now handled
through the mapping methods.  But should we remove the function then?

> 
> Do we want to backpatch this? If so, I'd need to produce a version
> that applies to the monolithic plpython.c file from the previous
> releases. 

I don't think this should be backpatched.



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Draft release notes complete
Next
From: Ants Aasma
Date:
Subject: Re: Gsoc2012 idea, tablesample