Re: PL/Python result set slicing broken in Python 3 - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: PL/Python result set slicing broken in Python 3
Date
Msg-id 1336668716.29567.7.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: PL/Python result set slicing broken in Python 3  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On tor, 2012-05-10 at 12:37 -0400, Robert Haas wrote:
> On Sat, May 5, 2012 at 4:45 PM, Jan Urbański <wulczer@wulczer.org> wrote:
> >> I found some instructions on how to deal with the Python 2/Python 3
> >> slicing mess:
> >>
> >>
> >> http://renesd.blogspot.com/2009/07/python3-c-api-simple-slicing-sqslice.html
> >
> >
> > Thanks to the helpful folk at #python I found out that the fix is much
> > easier. Attached is a patch that fixes the bug and passes regression tests
> > on Pythons 2.3 through 3.2.
> >
> > Apparently once you implement PyMappingMethods.mp_subscript you can drop
> > PySequenceMethods.sq_slice, but I guess there's no harm in keeping it (and
> > I'm not sure it'd work on Python 2.3 with only mp_subscript implemented).
> >
> > Do we want to backpatch this? If so, I'd need to produce a version that
> > applies to the monolithic plpython.c file from the previous releases.
> 
> Did this get forgotten about?

I'm working on it.



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Draft release notes complete
Next
From: Tom Lane
Date:
Subject: Re: "pgstat wait timeout" just got a lot more common on Windows