Re: Limit the size of explainPopup - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject Re: Limit the size of explainPopup
Date
Msg-id 1336422166.2320.56.camel@localhost.localdomain
Whole thread Raw
In response to Limit the size of explainPopup  (Clemens Eisserer <linuxhippy@gmail.com>)
Responses Re: Limit the size of explainPopup  (Clemens Eisserer <linuxhippy@gmail.com>)
List pgadmin-hackers
On Sat, 2012-05-05 at 13:09 +0200, Clemens Eisserer wrote:
> Hi,
>
> I often use pgadmin's graphical explain to see how queries generated
> be hibernate are planned&executed by postgresql, and it works really
> well.
> However, for very long queries pgadmin3 tries to create windows >
> 65536 pixels, which is not supported by X11 and therefor leads to
> XErrors, which in turn cause pgadmin3 to close because of assetions.
>
> I would propose to limit the size of the ExplainPopup to the screen
> dimensions, please see the attached patch.
>

Seems good to me. So I commited it. I had to change it a lot to apply it
to master, but it's commited too there.

Thanks for your patch.


--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com


pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: pgAdmin III commit: Fix crashes by limiting the size of explainPopup
Next
From: Guillaume Lelarge
Date:
Subject: pgAdmin III commit: Don't reset breakpoints when folding code