about EncodeDateTime() arguments - Mailing list pgsql-hackers

From Peter Eisentraut
Subject about EncodeDateTime() arguments
Date
Msg-id 1331419165.23793.4.camel@vanquo.pezone.net
Whole thread Raw
Responses Re: about EncodeDateTime() arguments
List pgsql-hackers
We currently have

void EncodeDateTime(struct pg_tm * tm, fsec_t fsec, int *tzp, char **tzn, int style, char *str)

but tzn isn't used anywhere, only *tzn is used everywhere.  Wouldn't it
be clearer to remove that one level of indirection and instead have the
signature be

void EncodeDateTime(struct pg_tm * tm, fsec_t fsec, int *tzp, char *tzn, int style, char *str)

or better yet

void EncodeDateTime(struct pg_tm * tm, fsec_t fsec, const int *tzp, const char *tzn, int style, char *str)





pgsql-hackers by date:

Previous
From: Yeb Havinga
Date:
Subject: Re: [v9.2] Add GUC sepgsql.client_label
Next
From: Peter Geoghegan
Date:
Subject: Re: Is it time for triage on the open patches?