Re: add_missing_from breaks existing views - Mailing list pgsql-hackers

From Tom Lane
Subject Re: add_missing_from breaks existing views
Date
Msg-id 1328.1130297936@sss.pgh.pa.us
Whole thread Raw
In response to Re: add_missing_from breaks existing views  (Neil Conway <neilc@samurai.com>)
Responses Re: add_missing_from breaks existing views
List pgsql-hackers
Neil Conway <neilc@samurai.com> writes:
> On Tue, 2005-25-10 at 17:43 -0400, Tom Lane wrote:
>> What I suggest we do about this is change addImplicitRTE() to set
>> inFromCl true for implicitly added RTEs, so that the view rule will
>> later be dumped as if the query had been written per spec.

> Sounds reasonable. I wonder if this should be backpatched -- ISTM the
> proper representation of the view is with an explicit FROM list anyway,

I think it'd be reasonable to back-patch it into the branches that have
the add_missing_from variable (how far back did we add that?).  But that
won't fix the problem with incompatible dump files from existing
installations.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: The use of (mb)print.c from psql in the scripts directory
Next
From: Tom Lane
Date:
Subject: Re: add_missing_from breaks existing views