Re: pgsql: Fix some warnings (probably actual bugs) generated by new GSSAPI - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix some warnings (probably actual bugs) generated by new GSSAPI
Date
Msg-id 13205.1184280669@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix some warnings (probably actual bugs) generated by new GSSAPI  (Neil Conway <neilc@samurai.com>)
List pgsql-committers
Neil Conway <neilc@samurai.com> writes:
> On Thu, 2007-07-12 at 17:36 -0300, Tom Lane wrote:
>> Fix some warnings (probably actual bugs) generated by new GSSAPI code
>> when built on a 64-bit machine.  Per buildfarm results extracted by Stefan.

> Wouldn't it be more correct to cast size_t to unsigned long, rather than
> unsigned int? Obviously getting GSS tokens larger than an unsigned int
> is unlikely to say the least, so it's probably not a problem in
> practice.

Feel free to change it if you want; I don't think it's an issue as long
as the cast matches the sprintf format.

            regards, tom lane

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Suppress Sun Studio warnings, per Stefan.
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Simplify overly-cute array coding to avoid an apparent gcc bug,