Re: Range Types - typo + NULL string constructor - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: Range Types - typo + NULL string constructor
Date
Msg-id 1317958902.1724.70.camel@jdavis
Whole thread Raw
In response to Re: Range Types - typo + NULL string constructor  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: Range Types - typo + NULL string constructor
List pgsql-hackers
On Thu, 2011-10-06 at 23:26 +0400, Alexander Korotkov wrote:
> Hi, Jeff!
> 
> 
> Heikki has recently commited my patch about picksplit for GiST on
> points and boxes:
> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=7f3bd86843e5aad84585a57d3f6b80db3c609916
> I would like to try this picksplit method on ranges. I believe that it
> might be much more efficient on highly overlapping ranges than current
> picksplit. Range types patch isn't commited, yet. So, what way of work
> publishing is prefered in this case? Add-on patch, separate branch in
> git or something else?

Sounds great! Thank you.

The repo is available here:

http://git.postgresql.org/gitweb/?p=users/jdavis/postgres.git;a=log;h=refs/heads/rangetypes

I'd prefer to include it in the initial patch. If the current GiST code
is going to be replaced, then there's not much sense reviewing/testing
it.

You may need to consider unbounded and empty ranges specially. I made an
attempt to do so in the current GiST code, and you might want to take a
look at that first. I'm not particularly attached to my approach, but we
should do something reasonable with unbounded and empty ranges.

Regards,Jeff Davis



pgsql-hackers by date:

Previous
From: Alex Hunsaker
Date:
Subject: Re: alter table only ... drop constraint broken in HEAD
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: [v9.2] make_greater_string() does not return a string in some cases