Re: Bug with pg_ctl -w/wait and config-only directories - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Bug with pg_ctl -w/wait and config-only directories
Date
Msg-id 1317668814-sup-6101@alvh.no-ip.org
Whole thread Raw
In response to Re: Bug with pg_ctl -w/wait and config-only directories  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Bug with pg_ctl -w/wait and config-only directories
List pgsql-hackers
Excerpts from Bruce Momjian's message of lun oct 03 16:03:47 -0300 2011:

> > I'm not sure how big the overlap is - would it be easier if you moved
> > the required functionality into pg_upgrade itself, as you mentioned at
> > some point? As in, would it be easier to fix the config-only directory
> > case for the limited subset of functionality that pg_upgrade needs?
> 
> Not really --- it is the -w/wait mode pg_upgrade needs. There is a lot
> of new code in pg_ctl that reads the postmaster.pid file for socket
> location, port number, etc, that doesn't make sense to duplicate. 
> Frankly, there is the huge problem that they might specify the data
> directory on the command line --- that would be a bear to support.

How about creating a library with the controlling stuff that's shared by
pg_ctl and pg_upgrade?

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [REVIEW] pg_last_xact_insert_timestamp
Next
From: Bruce Momjian
Date:
Subject: Re: Bug with pg_ctl -w/wait and config-only directories