Re: pgwin32_safestat weirdness - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgwin32_safestat weirdness
Date
Msg-id 13174.1208270055@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgwin32_safestat weirdness  (Magnus Hagander <magnus@hagander.net>)
Responses Re: pgwin32_safestat weirdness  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> Shouldn't be too hard to do, but I keep thinking it'd be cleaner to
> just not do the redefine when building libpq. It means we'd add a
> define like BUILDING_LIBPQ or something to the libpq Makefile, and
> exclude the redefine if set. 

+1 for that general approach, but let's call the macro something
like UNSAFE_STAT_OKAY.  If the day ever comes that we need safestat
inside libpq, or more likely that we want to exclude it from some
other piece of code, it'll be clearer what to do.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Problem with site doc search
Next
From: Magnus Hagander
Date:
Subject: Re: pgwin32_safestat weirdness