Re: citext operator precedence fix - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: citext operator precedence fix
Date
Msg-id 1316714786-sup-8212@alvh.no-ip.org
Whole thread Raw
In response to Re: citext operator precedence fix  ("David E. Wheeler" <david@kineticode.com>)
Responses Re: citext operator precedence fix
List pgsql-hackers
Excerpts from David E. Wheeler's message of jue sep 22 14:51:59 -0300 2011:
> On Sep 22, 2011, at 10:50 AM, Josh Berkus wrote:
> 
> >> Just write some comparisons like upthread, and see if the output is f or t. Put them into sql/citext.sql.
> > 
> > Oh, ok.  I thought you meant checking the actual function call.
> > 
> > Tests go in the main SQL file?  Shouldn't they have their own file?
> 
> That is the test file. The main SQL file is citext--1.0.sql. You'll actually need to bump the version number to 1.1,
renamethat file to citext--1.1.sql, and also add them to a citext--1.0--1.1.sql. There probably also needs to be a
citext--unpackaged--1.1.sqlfile.
 

Hmm, if there's a citext--unpackaged--1.0.sql and also
citext--1.0--1.1.sql, is it really necessary to have
citext--unpackaged--1.1.sql?  Shouldn't the upgrade facility be able to
just run both scripts?

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: "David E. Wheeler"
Date:
Subject: Re: citext operator precedence fix
Next
From: "David E. Wheeler"
Date:
Subject: Re: citext operator precedence fix