Re: pgAdmin III commit: Fix the removing of an inherited table - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject Re: pgAdmin III commit: Fix the removing of an inherited table
Date
Msg-id 1316461738.2114.41.camel@localhost.localdomain
Whole thread Raw
In response to Re: pgAdmin III commit: Fix the removing of an inherited table  (Dave Page <dpage@pgadmin.org>)
Responses Re: pgAdmin III commit: Fix the removing of an inherited table
List pgadmin-hackers
On Mon, 2011-09-19 at 14:28 -0500, Dave Page wrote:
> On Mon, Sep 19, 2011 at 2:18 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
> > On Mon, 2011-09-19 at 14:10 -0500, Dave Page wrote:
> >> That doesn't seem right - the user shouldn't  see quoting, except in SQL
> >> queries.
> >>
> >
> > We show the user the schema and the table names. It would be weird to
> > display foo.bar.something if the schema name is foo.bar and the table
> > name is something. We could use two columns, of course, but I don't
> > really see the point.
> >
> > Anyway, it was already displayed that way. I just fixed the issue. So,
> > if you want to fix the display, be my guest :)
>
> My point is that you haven't actually fixed the original bug; you've
> made it worse by further propagating the original issue.
>

So, what should we do? display two columns? how will that work on the
combobox?

I agree to work on this once we've found a good way to deal with it, but
we don't have one right now. And actually, the current patch fixes the
OP's issue, and that's good enough for me.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgAdmin III commit: Fix the removing of an inherited table
Next
From: Dave Page
Date:
Subject: Re: pgAdmin III commit: Fix the removing of an inherited table