Re: Potential NULL dereference found in typecmds.c - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Potential NULL dereference found in typecmds.c
Date
Msg-id 1309792308-sup-8903@alvh.no-ip.org
Whole thread Raw
In response to Re: Potential NULL dereference found in typecmds.c  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: Potential NULL dereference found in typecmds.c
List pgsql-hackers
Excerpts from Heikki Linnakangas's message of lun jul 04 09:14:11 -0400 2011:
> On 04.07.2011 16:07, Peter Geoghegan wrote:

> That error message is bogus anyway:
> 
> >     if (!found)
> >         ereport(ERROR,
> >                 (errcode(ERRCODE_UNDEFINED_OBJECT),
> >                  errmsg("constraint \"%s\" of domain \"%s\" does not exist",
> >                         constrName, NameStr(con->conname))));
> 
> It passes con->conname as the name of the domain, which is just wrong. 
> It should be TypeNameToString(typename) instead. The second error 
> message that follows has the same bug.

Um, evidently this code has a problem.  I'll fix.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Problem installing odbc and .Net drivers on Windows 7 64 Ultimate
Next
From: Peter Eisentraut
Date:
Subject: proper format for printing GetLastError()