Re: Remove one use of IDENT_USERNAME_MAX - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Remove one use of IDENT_USERNAME_MAX
Date
Msg-id 13092.1572359640@sss.pgh.pa.us
Whole thread Raw
In response to Re: Remove one use of IDENT_USERNAME_MAX  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: Remove one use of IDENT_USERNAME_MAX  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2019-10-28 14:45, Tom Lane wrote:
>> Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
>>> In think one of the reasons for the coding is the fact that *pw is
>>> described to be placed in the static area, which can be overwritten by
>>> succeeding calls to getpw*() functions.

>> Good point ... so maybe pstrdup instead of using a fixed-size buffer?

> Maybe.  Or we just decide that check_usermap() is not allowed to call 
> getpw*().  It's just a string-matching routine, so it doesn't have any 
> such business anyway.

I'm okay with that as long as you add a comment describing this
assumption.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Shay Rojansky
Date:
Subject: Re: strpos behavior change around empty substring in PG12
Next
From: Peter Eisentraut
Date:
Subject: Re: Add const qualifiers to internal range type APIs