On fre, 2011-06-24 at 16:34 -0400, Bruce Momjian wrote:
> > > It also creates two new environment variables,
> > > OLDPGPORT and NEWPGPORT, to control the port values because we
> don't
> > > want to default to PGPORT anymore.
> >
> > I would prefer that all PostgreSQL-related environment variables
> start
> > with "PG".
>
> OK, attached. I was also using environment variables for PGDATA and
> PGBIN do I renamed those too to begin with 'PG'.
I'm wondering why pg_upgrade needs environment variables at all. It's a
one-shot operation. Environment variables are typically used to shared
default settings across programs. I don't see how that applies here.
