Re: [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address
Date
Msg-id 1308761379-sup-6825@alvh.no-ip.org
Whole thread Raw
In response to Re: [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address
List pgsql-hackers
Excerpts from Robert Haas's message of mié jun 22 08:56:02 -0400 2011:

> Another option might be to leave heap_openrv() and relation_openrv()
> alone and add a missing_ok argument to try_heap_openrv() and
> try_relation_openrv().  Passing true would give the same behavior as
> presently; passing false would make them behave like the non-try
> version.

That would be pretty weird, having two functions, one of them sometimes
doing the same thing as the other one.

I understand Noah's concern but I think your original proposal was saner
than both options presented so far.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Coding style point: "const" in function parameter declarations
Next
From: Alvaro Herrera
Date:
Subject: Re: Indication of db-shared tables