Excerpts from Brendan Jurd's message of lun jun 20 20:06:39 -0400 2011:
> On 21 June 2011 06:06, Alvaro Herrera <alvherre@commandprompt.com> wrote:
> > Excerpts from Alvaro Herrera's message of lun jun 20 12:19:37 -0400 2011:
> >> Excerpts from Pavel Stehule's message of lun jun 20 11:34:25 -0400 2011:
> >>
> >> > b) probably you can simplify a memory management using own two
> >> > persistent memory context - and you can swap it. Then functions like
> >> > free_hba_record, clean_hba_list, free_lines should be removed.
> >>
> >> Yeah, I reworked the patch with something like that over the weekend.
> >> Not all of it though. I'll send an updated version shortly.
> >
> > Here it is, please let me know what you think. I took the liberty of
> > cleaning up some things that were clearly historical leftovers.
> >
>
> Okay, yeah, the MemoryContext approach is far more elegant than what I
> had. Boy was I ever barking up the wrong tree.
Eh, whoever wrote the original code was barking up the same tree, so I
don't blame you for following the well-trodden path.
I realize I took out most of the fun of this patch from you, but -- are
you still planning to do some more exhaustive testing of it? I checked
some funny scenarios (including include files and groups) but it's not
all that unlikely that I missed some cases. I also didn't check any
auth method other than ident, md5 and trust, 'cause I don't have what's
required for anything else. (It's a pity that the regression tests
don't exercise anything else.)
--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
