Re: Discussion - Search Objects - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject Re: Discussion - Search Objects
Date
Msg-id 1308173936.1993.90.camel@laptop
Whole thread Raw
In response to Re: Discussion - Search Objects  (Guillaume Lelarge <guillaume@lelarge.info>)
Responses Re: Discussion - Search Objects
List pgadmin-hackers
On Wed, 2011-06-15 at 08:08 +0200, Guillaume Lelarge wrote:
> On Wed, 2011-06-15 at 01:03 +0200, Jasmin Dizdarevic wrote:
> > Hi,
> >
> >
> > please take another look on it. The UI should work correctly now.
> >
> >
> > Linux make files should also be correct now.
> >
>
> It works much better now. You still have one issue with primary key (and
> I guess, unique constraint and exclusive constraints too). You show them
> as constraints and indexes, whereas pgAdmin only shows them as
> constraints. You shouldn't display indexes for constraints with implicit
> indexes.
>
> And I didn't look at the code yet.
>

Seems mostly good. The only question I have is: why did you choose to
name it frm* instead of dlg*? it behaves as a dialog, not as a form.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: Re: Ownership of a new view
Next
From: Jasmin Dizdarevic
Date:
Subject: Re: Discussion - Search Objects