Re: pgsql: Add TAP tests for pg_verify_checksums - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgsql: Add TAP tests for pg_verify_checksums
Date
Msg-id 1307.1539960789@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Add TAP tests for pg_verify_checksums  (Michael Banck <michael.banck@credativ.de>)
Responses Re: pgsql: Add TAP tests for pg_verify_checksums  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Michael Banck <michael.banck@credativ.de> writes:
> Am Freitag, den 19.10.2018, 10:36 -0400 schrieb Stephen Frost:
>> I just saw this committed and I'm trying to figure out why we are
>> creating yet-another-list when it comes to deciding what should be
>> checksum'd and what shouldn't be.

> To be fair, the list in src/backend/replication/basebackup.c was a copy-
> paste from the one in pg_verify_checksums (or from other parts of the 
> online activation patch).

Seems like a job for a new(?) module in src/common/.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Michael Banck
Date:
Subject: Re: pgsql: Add TAP tests for pg_verify_checksums
Next
From: Stephen Frost
Date:
Subject: Re: pgsql: Add TAP tests for pg_verify_checksums