Hi Peter,
>> Either way is fine by me. It just seemed like the majority of commenters
>> where in favor of keeping some type in the GIN code for readability.
>
> After further consideration, I think it is best to leave this alone as
> is. One particular problem is that Pointer is part of the documented
> API of GIN, and if we either remove it or rename it, then this would
> create a bunch of work for extensions to keep their code compiling
> across major versions.
That's a pity. It would have been a nice cleanup of some crufty code
that makes readability harder than needed. Seems like a simple rename
would be acceptable in the spirit of e.g. [1].
--
David Geier
[1]
https://www.postgresql.org/message-id/2273bc2a-045d-4a75-8584-7cd9396e5534%40eisentraut.org
