Re: clang's -Wmissing-variable-declarations shows some shoddy programming - Mailing list pgsql-hackers

From Tom Lane
Subject Re: clang's -Wmissing-variable-declarations shows some shoddy programming
Date
Msg-id 13056.1387041265@sss.pgh.pa.us
Whole thread Raw
In response to clang's -Wmissing-variable-declarations shows some shoddy programming  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: clang's -Wmissing-variable-declarations shows some shoddy programming
List pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> Compiling postgres with said option in CFLAGS really gives an astounding
> number of warnings. Except some bison/flex generated ones, none of them
> looks acceptable to me.

Given that we're not going to be able to get rid of the bison/flex cases,
is this really something to bother with?  I agree I don't like cases where
there's an "extern" in some other .c file rather than in a header, but I'm
dubious about making a goal of suppressing this warning as such.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Changeset Extraction Interfaces
Next
From: Andres Freund
Date:
Subject: Re: Changeset Extraction Interfaces