Re: [COMMITTERS] pgsql: Message style cleanup - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [COMMITTERS] pgsql: Message style cleanup
Date
Msg-id 1304536194.18730.2.camel@vanquo.pezone.net
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Message style cleanup  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On ons, 2011-05-04 at 20:32 +0200, Magnus Hagander wrote:
> Is this part really correct?
> 
> -       fprintf(stderr, _("%s: final receive failed: %s\n"),
> +       fprintf(stderr, _("%s: final receive failed: %s"),
> 
> all other msgs have \n.. I see you removed the final dot in many of
> the other messages, did you just accidentally grab one too  many?
> (There are a couple of other examples of removing the \n though, so
> perhaps it was  intentional? But they're all preceeding
> disconnect_and_exit() so I don't see why it shouldn't be consistent?

The result of PQerrorMessage() already ends in \n.

With that in mind, maybe I missed something?




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Extreme bloating of intarray GiST indexes
Next
From: Magnus Hagander
Date:
Subject: Re: [COMMITTERS] pgsql: Message style cleanup