Re: Sync Rep v19 - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Sync Rep v19
Date
Msg-id 1299400021.1696.72.camel@ebony
Whole thread Raw
In response to Re: Sync Rep v19  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Sun, 2011-03-06 at 01:58 +0900, Fujii Masao wrote:
> On Sun, Mar 6, 2011 at 12:42 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> > New comments;
> 
> Another one;
> 
> +    long        timeout = SyncRepGetWaitTimeout();
> <snip>
> +            else if (timeout > 0 &&
> +                TimestampDifferenceExceeds(wait_start, now, timeout))
> +            {
> 
> The third argument of TimestampDifferenceExceeds is
> expressed in milliseconds. But you wrongly give that the
> microseconds.

Just for the record: that code section is now removed in v21

-- Simon Riggs           http://www.2ndQuadrant.com/books/PostgreSQL Development, 24x7 Support, Training and Services



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Sync Rep v19
Next
From: Bruce Momjian
Date:
Subject: Improve check for TOAST checks in pre-8.4 pg_upgrade servers