On Thu, 2011-02-10 at 12:04 -0500, Tom Lane wrote:
> "Erik Rijkers" <er@xs4all.nl> writes:
> > On Wed, February 9, 2011 09:35, Jeff Davis wrote:
> >> Updated patch.
>
> > I just wanted to mention that this latest patch doesn't quite apply as-is, because of catversion changes.
>
> Just a note: standard practice is for submitted patches to *not* touch
> catversion.h. The committer will add that change before committing.
> Otherwise, it's just guaranteed to cause merge problems such as this
> one. (It's not unreasonable to mention the need for a catversion bump
> in the description of the patch, if you think the committer might not
> realize it.)
OK, I'll remove that then.
I originally put it there so that I wouldn't mix up data directories
with a patch I'm reviewing, but I agree that it seems easier this way.
Regards,Jeff Davis
