Re: Add ENCODING option to COPY - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Add ENCODING option to COPY
Date
Msg-id 1297179761.24949.2.camel@fsopti579.F-Secure.com
Whole thread Raw
In response to Re: Add ENCODING option to COPY  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Add ENCODING option to COPY  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On fre, 2011-02-04 at 10:47 -0500, Tom Lane wrote:
> The reason that we use quotes in CREATE DATABASE is that encoding
> names aren't assumed to be valid SQL identifiers.  If this patch isn't
> following the CREATE DATABASE precedent, it's the patch that's wrong,
> not CREATE DATABASE.

Since encoding names are built-in and therefore well known, and the
names have been aligned with the SQL standard names, which are
identifiers, I don't think this argument is valid (anymore).

It probably shouldn't be changed inconsistently as part of an unrelated
patch, but I think the idea has merit.



pgsql-hackers by date:

Previous
From: Dan Ports
Date:
Subject: Re: SSI patch version 14
Next
From: Pavel Stehule
Date:
Subject: Re: Re: patch: fix performance problems with repated decomprimation of varlena values in plpgsql